Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect pattern matching in PersonAgent.scala #3746

Closed
HoneyTauOverTwo opened this issue Apr 27, 2023 · 1 comment · May be fixed by #3760
Closed

Incorrect pattern matching in PersonAgent.scala #3746

HoneyTauOverTwo opened this issue Apr 27, 2023 · 1 comment · May be fixed by #3760
Assignees
@HoneyTauOverTwo

Comments

@HoneyTauOverTwo
Copy link
Collaborator

https://github.com/LBNL-UCB-STI/beam/blob/develop/src/main/scala/beam/agentsim/agents/PersonAgent.scala#L961:

data @ BasePersonData(
            _,
            _,
            currentTrip @ headOfCurrentTrip :: restOfCurrentTrip,
            _,
            _,
            _,
            _,
            _,
            _,
            _,
            currentCost,
            _,
            _,
            enrouteData
          )

currentCost is positioned to match BasePersonData.numberOfReplanningAttempts (int) instead of BasePersonData.currentTripCosts (double)

The fix for this should also include a test to make sure this is set properly.
@HoneyTauOverTwo HoneyTauOverTwo self-assigned this May 5, 2023
HoneyTauOverTwo added a commit that referenced this issue Jul 12, 2023
@HoneyTauOverTwo
Adds test to check if PersonCostEvents match the expected trip cost c…
ee2921c 
…alculated by using their respective PathTraversalEvents.

This was made to cover a bug described on issue #3746.

This test will not be passing on this commit since the fix for issue #3746 is not being pushed alongside it.
@HoneyTauOverTwo HoneyTauOverTwo linked a pull request Jul 12, 2023 that will close this issue
Adds tests to check if PersonCostEvents match their expected trip costs #3760
Draft
HoneyTauOverTwo added a commit that referenced this issue Jul 12, 2023
@HoneyTauOverTwo
Adds fix to issue #3746. PersonAgentTripCostTest is flaky at this sta…
1efad39 
…ge meaning there are other sources for cost discrepancy.
@dimaopen
Copy link
Collaborator

This defect seemed to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HoneyTauOverTwo HoneyTauOverTwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds tests to check if PersonCostEvents match their expected trip costs LBNL-UCB-STI/beam
2 participants
@dimaopen @HoneyTauOverTwo