Clean up CR code

[samadejacobs]

There are quite a number of commented checkpoint/restart code, are these placeholders? if not we should clean them up.
e.g. (in layers.cpp):

bool Layer::saveToCheckpoint(int fd, const char *filename, size_t *bytes) const {
//writeDist(fd, filename, *m_weights, bytes);

// Need to catch return value from function
// m_optimizer->saveToCheckpoint(fd, filename, bytes);
return true;
}

bool Layer::loadFromCheckpoint(int fd, const char *filename, size_t *bytes) {
// TODO: implement reader for other matrix distributions
//readDist(fd, filename, (DistMat&) *m_weights, bytes);

// Need to catch return value from function
// m_optimizer->loadFromCheckpoint(fd, filename, bytes);
return true;
}

bool Layer::save_to_checkpoint_shared(persist& p) const {
//for (weights *w : m_weights) {
// w->saveToCheckpointShared(p);
//}
return true;
}

bool Layer::load_from_checkpoint_shared(persist& p) {
//for (weights *w : m_weights) {
// w->loadFromCheckpointShared(p);
//}

return true;
}

[bvanessen]

Let’s not delete any of these until Dylan has a proper test harness in place to make sure that we have fully working checkpoints. At the moment I view these as notes to go and make sure that the object is properly saving all its state. Brian C. Van Essen [email protected]<mailto:[email protected]> (w) 925-422-9300 (c) 925-290-5470

…

---

Sent from my iPhone On Dec 24, 2017, at 6:22 AM, Sam Ade Jacobs <[email protected]<mailto:[email protected]>> wrote: There are quite a number of commented checkpoint/restart code, are these placeholders? if not we should clean them up. e.g. (in layers.cpp): bool Layer::saveToCheckpoint(int fd, const char *filename, size_t *bytes) const { //writeDist(fd, filename, *m_weights, bytes); // Need to catch return value from function // m_optimizer->saveToCheckpoint(fd, filename, bytes); return true; } bool Layer::loadFromCheckpoint(int fd, const char *filename, size_t *bytes) { // TODO: implement reader for other matrix distributions //readDist(fd, filename, (DistMat&) *m_weights, bytes); // Need to catch return value from function // m_optimizer->loadFromCheckpoint(fd, filename, bytes); return true; } bool Layer::save_to_checkpoint_shared(persist& p) const { //for (weights *w : m_weights) { // w->saveToCheckpointShared(p); //} return true; } bool Layer::load_from_checkpoint_shared(persist& p) { //for (weights *w : m_weights) { // w->loadFromCheckpointShared(p); //} return true; } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#156>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF7Ce4CrOWpaWNs8B5kMFQl4qIAdZxHcks5tDl4fgaJpZM4RL7-2>.