-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Embed #930
Comments
The full screen button missing is because you need to add
attributes. Adding https://github.com/LA1TV/Website/blob/master/docs/Embeddable%20Player.md |
Actually This could be fixed by making this variable
false if $showHeading is false
|
Adding the options didn't work. Currently working on a deployment system so you can see what we are on about. Have I added the options correctly here? |
No the player settings are query parameters so need seeing to the URL like The disableFullscreen shouldn't be needed. I guess the full screen attributes aren't being set for some reason through react. You could check by inspecting the element in dev tools. I'm guessing in react it might need to be |
Actually this made me realise as well as need to support the same URL to an item as the current site so that links from embeds in other places still go to the right place on the new site :) |
No fullscreen button. Also, redirects by pressing name at top.
The text was updated successfully, but these errors were encountered: