Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Embed #930

Open
m3lnic opened this issue Jul 23, 2019 · 5 comments
Open

Video Embed #930

m3lnic opened this issue Jul 23, 2019 · 5 comments

Comments

@m3lnic
Copy link

m3lnic commented Jul 23, 2019

image

No fullscreen button. Also, redirects by pressing name at top.

@tjenkinson
Copy link
Member

The full screen button missing is because you need to add

  • allowfullscreen
  • webkitallowfullscreen
  • mozallowfullscreen

attributes.

Adding ?showHeading=0 should remove the heading

https://github.com/LA1TV/Website/blob/master/docs/Embeddable%20Player.md

@tjenkinson
Copy link
Member

Actually showHeading currently only works for ?flush=0.

This could be fixed by making this variable

$showTitleInPlayer = !$kioskMode && $flushMode;
false if $showHeading is false

@m3lnic
Copy link
Author

m3lnic commented Jul 23, 2019

Adding the options didn't work.

Currently working on a deployment system so you can see what we are on about.

Have I added the options correctly here?

@tjenkinson
Copy link
Member

tjenkinson commented Jul 24, 2019

No the player settings are query parameters so need seeing to the URL like ?option1=1&option2=2 etc.

The disableFullscreen shouldn't be needed. I guess the full screen attributes aren't being set for some reason through react. You could check by inspecting the element in dev tools.

I'm guessing in react it might need to be enableFullScreen or enableFullscreen etc

@tjenkinson
Copy link
Member

Actually this made me realise as well as need to support the same URL to an item as the current site so that links from embeds in other places still go to the right place on the new site :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants