Potential bug fix for nested types codegen jupyter #1223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222
Made it so that nested types in jupyter codegen follow their parent's openness. This makes it so that:
produces something like:
However, the old behavior (whenever a schema is generated, nested types, such as inside column groups and frame cols are generated with isOpen = false, even if the data schema itself has isOpen = true) has been like this since at least 2021.
This change makes this test fail, which indicates to me that it might have been done intentionally. @koperagen could you maybe explain a bit more about this behavior now that we know it can cause bugs like these?