Skip to content

Bug with line break in column name props generation + align renameToCamelCase and normalization behavior #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
AndreiKingsley opened this issue May 13, 2025 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@AndreiKingsley
Copy link
Collaborator

AndreiKingsley commented May 13, 2025

Bug:

Image
  • In DataFrame renameToCamelCase API
  • in compiler plugin (should be 😄)
  • in NameNormalizer.Companion.default
  • in ValidFieldName.Companion#of
  • jupyter codegen

Might be other places, need to inspect.

@AndreiKingsley AndreiKingsley added the bug Something isn't working label May 13, 2025
@koperagen
Copy link
Collaborator

koperagen commented May 13, 2025

Changing org.jetbrains.kotlinx.dataframe.codeGen.ValidFieldName.Companion#of should fix it for both compiler plugin and jupyter codegen
NameNormalizer.Companion.default serves different purpose: in KSP and Gradle plugins, when schema is generated from data, it renames extension properties to camel case (old logic) but keeps column names in df intact. I think now that we have renameToCamelCase support in compiler plugin, it's somewhat outdated feature. Anyway doesn't work in jupyter notebooks - there we get names "as is", except ValidFieldName.Companion#of fixes names that otherwise won't compile

So to summarize
ValidFieldName.Companion#of -> fixes invalid symbols in identifiers created from data (string arguments, or infered from CSV), used by jupyter and compiler plugin
NameNormalizer -> stylistic feature that made sense for KSP/Gradle

@Jolanrensen Jolanrensen added this to the 1.0.0-Beta2 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants