Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all online dependencies #173

Open
KosmosisDire opened this issue Aug 7, 2023 · 3 comments
Open

Remove all online dependencies #173

KosmosisDire opened this issue Aug 7, 2023 · 3 comments
Labels
approved This issue has been approved and will be implemented in the future enhancement New feature or request

Comments

@KosmosisDire
Copy link
Owner

Right now some libraries and resources are loaded from the internet. Preferably these should be packaged with the export so everything will load even if the html file is opened offline.

@KosmosisDire KosmosisDire added the enhancement New feature or request label Aug 7, 2023
@ItsRoy69
Copy link

ItsRoy69 commented Aug 7, 2023

I can work on this issue, it will be great if I am being assigned to work on this issue.

@KosmosisDire
Copy link
Owner Author

KosmosisDire commented Aug 7, 2023

Thank you for offering! I'd be happy to let you work on this. There are a number of somewhat hidden dependecies which rely on fetching things from obsidian's publish server. Some of these urls may be generated automatically, so make sure to test it offline to find all the URLs

Thanks again :)

@KosmosisDire KosmosisDire added the approved This issue has been approved and will be implemented in the future label Aug 7, 2023
@KosmosisDire
Copy link
Owner Author

@ItsRoy69 Hi I have made a lot of changes to the way assets are handled that has made this possible to easily implement. As such I went ahead and implemented it since I haven't seen any activity on your fork, and the changes would also likely make a different solution obsolete. I will be pushing these changes to the 1.7.4 branch soon.

@ItsRoy69 ItsRoy69 removed their assignment Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue has been approved and will be implemented in the future enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants