Unable to set request body optionally

[bensullivan-ag]

Hi

Should the following pass?

@Test
void shouldAllowRequestBodiesToBeAppliedConditionally() {
    var maybeBody = Optional.of("test body");
    var request = Unirest.patch("api.com").header("Authorization", "Bearer XXXXXX");
    maybeBody.ifPresent((b) -> request.header("Content-Type", "application/json").body(b));
    assertTrue(request.getBody().isPresent());
    assertEquals(maybeBody.get(), request.getBody().get());
}

Thanks

[ryber]

It would if you configured an Object Mapper to understand what an Optional is. Otherwise it’s just going to call toString on it.

…

On Sun, Aug 11, 2024 at 7:54 PM bensullivan-ag ***@***.***> wrote: Hi Should the following pass? @test void shouldAllowRequestBodiesToBeAppliedConditionally() { var maybeBody = Optional.of("test body"); var request = Unirest.patch("api.com").header("Authorization", "Bearer XXXXXX"); maybeBody.ifPresent((b) -> request.header("Content-Type", "application/json").body(b)); assertTrue(request.getBody().isPresent()); assertEquals(maybeBody.get(), request.getBody().get()); } Thanks — Reply to this email directly, view it on GitHub <#529>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABDPT54FGB23KO5PQ5T6V3ZRABVDAVCNFSM6AAAAABMLGYBMOVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZXGA2DANJZHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[bensullivan-ag]

Thanks for reply.

Which line are you referring to?

b is a String and request.getBody() is an Optional..

[ryber]

Sorry I was reading it from my phone, I thought you were passing the Optional as the body. You don't even need the Optional at all to produce the same result. It could be this:

@Test
    void shouldAllowRequestBodiesToBeAppliedConditionally() {
        var request = Unirest.patch(MockServer.PATCH).header("Authorization", "Bearer XXXXXX");
        request.header("Content-Type", "application/json").body("test body");
        assertTrue(request.getBody().isPresent());
        assertEquals("test body", request.getBody().get());
    }

but the answer is no, this would not work. "Test body" is a string, request.getBody().get() is a Body object. In this case you are looking at what Unirest is planning to ship. What "Body" actually represents is pretty complicated because it could include multipart forms. Additionally at the level you are working it will probably produce a empty optional as you are in the middle of the request process.

[ryber]

Oh another thing, the Unirest request object goes though different transformations as you build it. What is returned from .body("") is a DIFFERENT object from your request object. So the original "request" variable won't have a body, because it is a previous version of the chain.