From fc8985ded55d122e026c56aa6b9982348bdc0754 Mon Sep 17 00:00:00 2001 From: Thibault Charbonnier Date: Mon, 5 Feb 2024 18:52:24 -0800 Subject: [PATCH] chore(ci) specify 'timeout-minutes' on all jobs --- .github/workflows/ci-large.yml | 5 +++++ .github/workflows/ci.yml | 7 +++++++ .github/workflows/job-build-tests.yml | 1 + .github/workflows/release.yml | 12 ++++++++++++ 4 files changed, 25 insertions(+) diff --git a/.github/workflows/ci-large.yml b/.github/workflows/ci-large.yml index 35a6b85d8..37ce4106f 100644 --- a/.github/workflows/ci-large.yml +++ b/.github/workflows/ci-large.yml @@ -16,6 +16,7 @@ jobs: name: 'Unit' #if: ${{ false }} secrets: inherit + #timeout-minutes: see job-unit-tests.yml strategy: fail-fast: false matrix: @@ -61,6 +62,7 @@ jobs: valgrind: name: 'Valgrind' #if: ${{ false }} + #timeout-minutes: see job-valgrind-tests.yml strategy: fail-fast: false matrix: @@ -99,6 +101,7 @@ jobs: analyzer: name: 'Clang analyzer' + timeout-minutes: 30 strategy: fail-fast: false matrix: @@ -125,6 +128,7 @@ jobs: codeql: name: 'CodeQL analyzer' + timeout-minutes: 30 strategy: fail-fast: false matrix: @@ -140,6 +144,7 @@ jobs: build: name: 'Build' #if: ${{ false }} + #timeout-minutes: see job-build-tests.yml strategy: fail-fast: false matrix: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7ee0e9e6a..ca44891e1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,6 +26,7 @@ jobs: unit: name: 'Unit' #if: ${{ false }} + #timeout-minutes: see job-unit-tests.yml strategy: fail-fast: false matrix: @@ -133,6 +134,7 @@ jobs: name: 'Coveralls' needs: unit runs-on: ubuntu-latest + timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} steps: - name: Coveralls Finished if: ${{ !env.ACT }} @@ -145,6 +147,7 @@ jobs: valgrind: name: 'Valgrind' #if: ${{ false }} + #timeout-minutes: see job-valgrind-tests.yml strategy: fail-fast: false matrix: @@ -209,6 +212,7 @@ jobs: lint: name: 'Lint' runs-on: ubuntu-latest + timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} steps: - uses: actions/checkout@v3 - name: 'Setup cache - rustup toolchain' @@ -246,6 +250,7 @@ jobs: analyzer: name: 'Clang analyzer' + timeout-minutes: 30 strategy: fail-fast: false matrix: @@ -280,6 +285,7 @@ jobs: codeql: name: 'CodeQL analyzer' + timeout-minutes: 30 strategy: fail-fast: false matrix: @@ -295,6 +301,7 @@ jobs: build: name: 'Build' #if: ${{ false }} + #timeout-minutes: see job-build-tests.yml strategy: fail-fast: false matrix: diff --git a/.github/workflows/job-build-tests.yml b/.github/workflows/job-build-tests.yml index 98ad1623a..90dde3d6c 100644 --- a/.github/workflows/job-build-tests.yml +++ b/.github/workflows/job-build-tests.yml @@ -38,6 +38,7 @@ jobs: name: 'Build' #if: ${{ false }} runs-on: ${{ inputs.os }} + timeout-minutes: 45 steps: - name: 'Setup Ubuntu deps - gcc' if: ${{ !env.ACT && contains(inputs.os, 'ubuntu') && contains(inputs.cc, 'gcc') }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a7fc18c8a..3578ecbec 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,6 +34,7 @@ jobs: setup: name: "Setup release & runtime versions" runs-on: ubuntu-latest + timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} outputs: wasmtime_ver: ${{ steps.assign-versions.outputs.wasmtime_ver }} wasmer_ver: ${{ steps.assign-versions.outputs.wasmer_ver }} @@ -98,6 +99,7 @@ jobs: name: "Source release" needs: setup runs-on: ubuntu-latest + timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} steps: - uses: actions/checkout@v3 - name: Build archive @@ -112,6 +114,7 @@ jobs: build-images: name: "Build compilation images" runs-on: ubuntu-latest + timeout-minutes: 30 strategy: matrix: include: @@ -160,6 +163,7 @@ jobs: name: "Build Ubuntu 18.04 (bionic) binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -191,6 +195,7 @@ jobs: name: "Build Ubuntu 20.04 (focal) binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -222,6 +227,7 @@ jobs: name: "Build Ubuntu 22.04 (jammy) binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -253,6 +259,7 @@ jobs: name: "Build ARM Ubuntu 22.04 (jammy) binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 150 steps: - uses: actions/checkout@v3 - name: Setup QEMU @@ -292,6 +299,7 @@ jobs: name: "Build Centos 7 binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -323,6 +331,7 @@ jobs: name: "Build Centos 8 binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -354,6 +363,7 @@ jobs: name: "Build ArchLinux binary" needs: [setup, build-images] runs-on: ubuntu-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -385,6 +395,7 @@ jobs: name: "Build macOS binary" needs: [setup, build-images] runs-on: macos-latest + timeout-minutes: 120 env: WASMTIME_VER: ${{ needs.setup.outputs.wasmtime_ver }} WASMER_VER: ${{ needs.setup.outputs.wasmer_ver }} @@ -415,6 +426,7 @@ jobs: name: "Upload release artifacts" needs: [setup, source-release, binary-ubuntu-bionic, binary-ubuntu-focal, binary-ubuntu-jammy, binary-ubuntu-jammy-arm, binary-centos7, binary-centos8, binary-arch, binary-macos] runs-on: ubuntu-latest + timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }} steps: - name: Retrieve sibling release artifacts uses: actions/download-artifact@v3