Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New device support]: #24799

Open
audunmg opened this issue Nov 17, 2024 · 0 comments
Open

[New device support]: #24799

audunmg opened this issue Nov 17, 2024 · 0 comments
Labels
new device support New device support request

Comments

@audunmg
Copy link

audunmg commented Nov 17, 2024

Link

https://www.ikea.com/jp/en/p/tradfri-led-bulb-e17-810-lumen-wireless-dimmable-colour-and-white-spectrum-globe-opal-white-20547495/

Database entry

{"id":49,"type":"Router","ieeeAddr":"0x44e2f8fffe37f693","nwkAddr":16690,"manufId":4476,"manufName":"IKEA of Sweden","powerSource":"Mains (single phase)","modelId":"TRADFRI bulb E17 CWS globe 810lm","epList":[1,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":269,"inClusterList":[0,3,4,5,6,8,768,4096,64636],"outClusterList":[25],"clusters":{"genBasic":{"attributes":{"modelId":"TRADFRI bulb E17 CWS globe 810lm","manufacturerName":"IKEA of Sweden","powerSource":1,"zclVersion":8,"appVersion":1,"stackVersion":113,"hwVersion":1,"dateCode":"20230913","swBuildId":"1.0.38"}},"lightingColorCtrl":{"attributes":{"colorCapabilities":31,"colorTempPhysicalMin":250,"colorTempPhysicalMax":454,"colorMode":2,"currentX":22918,"currentY":23154,"colorTemperature":250}},"genOnOff":{"attributes":{"onOff":1,"startUpOnOff":1}},"genLevelCtrl":{"attributes":{"currentLevel":254}}},"binds":[],"configuredReportings":[],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[33],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":1,"stackVersion":113,"hwVersion":1,"dateCode":"20230913","swBuildId":"1.0.38","zclVersion":8,"interviewCompleted":true,"meta":{"configured":332242049},"lastSeen":1731810151789}

Zigbee2MQTT version

1.41.0-dev commit: 36e452b

Comments

Since I don't know what the correct approach is in this case, I opened an issue instead of a PR toward zigbee-herdsman-converters.

I added this stanza to the ikea.js to get it "supported":

    {
        zigbeeModel: ['TRADFRI bulb E17 CWS globe 810lm'],                                                                          
        model: 'LED2111G6', 
        vendor: 'IKEA of Sweden',
        description: 'TRADFRI bulb E12/E14/E17, color/white spectrum, globe, opal, 800/806/810 lm',
        extend: [(0, ikea_1.addCustomClusterManuSpecificIkeaUnknown)(), (0, ikea_1.ikeaLight)({ colorTemp: true, color: true }), (0, modernExtend_1.identify)()],
    },

but there is already this:

        zigbeeModel: ['TRADFRI bulb E14 CWS globe 806lm', 'TRADFRI bulb E12 CWS globe 800lm'],                                    
        model: 'LED2111G6',
        vendor: 'IKEA',
        description: 'TRADFRI bulb E12/E14/E17, color/white spectrum, globe, opal, 800/806/810 lm',
        extend: [(0, ikea_1.addCustomClusterManuSpecificIkeaUnknown)(), (0, ikea_1.ikeaLight)({ colorTemp: true, color: true }), (0, modernExtend_1.identify)()],
    },

I'm wondering if the correct approach would be to add it to the above and change the vendor:

        vendor: ['IKEA',  'IKEA of Sweden'],

This is the only device I have to report IKEA of Sweden as a vendor, but maybe more are coming? Who knows.

I'm happy to make a PR for this if you want, but since it's such a small change, it's probably faster and easier if you do the right thing.

Thank you for an awesome piece of software!

External definition

I admit I didn't create an external definition.

What does/doesn't work with the external definition?

I changed the internal definition instead.

The bulb works as expected in all functions with my change.

@audunmg audunmg added the new device support New device support request label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new device support New device support request
Projects
None yet
Development

No branches or pull requests

1 participant