Update efekta.ts #8028
Open
Update efekta.ts #8028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1
Koenkk
reviewed
Sep 27, 2024
| configure: async (device, coordinatorEndpoint, logger) => { | ||
| const endpointOne = device.getEndpoint(1); | ||
| const overrides0 = {min: 7200, max: 43200, change: 1}; | ||
| await reporting.batteryAlarmState(endpointOne, overrides0); |
There was a problem hiding this comment.
I think this can also be added as a modernExtend?
There was a problem hiding this comment.
That would be great, it doesn't work through the modern right now. As soon as you implement this, I will change efekta.ts
There was a problem hiding this comment.
Could you check if you can add this? Add batteryAlarmStateReporting to https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/modernExtend.ts#L285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for two new devices EFEKTA PST DUO V1 LR and EFEKTA PST DUO V1