Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow base path config for ALB handler #291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow base path config for ALB handler #291

wants to merge 4 commits into from

Conversation

nipun-AiR
Copy link

Closes #238

@jordaneremieff
Copy link
Collaborator

@nipun-AiR can you resolve the test coverage issues blocking the GH workflow from completing? I think okay to do # pragma: nocover if it's just the warning missing coverage.

I think this should be good to merge once passing the GH workflow.

@nipun-AiR
Copy link
Author

@jordaneremieff Thanks for the comment - added test coverage for the missing lines.

@jordaneremieff
Copy link
Collaborator

@nipun-AiR looks like tests are passing now but need to apply linting/formatting before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaneremieff jordaneremieff Awaiting requested review from jordaneremieff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api_gateway_base_path not supported for ALB?
2 participants
@nipun-AiR @jordaneremieff