Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental DICOM loading #606

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Incremental DICOM loading #606

wants to merge 20 commits into from

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Jun 13, 2024 •
edited
Loading

This PR updates VolView to support incremental DICOM loading. This is a pretty big change, so I hope to improve this issue description with details of how this is broken down.

Components:

@netlify Netlify
Copy link

netlify bot commented Jun 13, 2024 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 19e8af5
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/66b4143e23e412000895b2ca
😎 Deploy Preview https://deploy-preview-606--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax linked an issue Jun 26, 2024 that may be closed by this pull request
Image range and histogram computation: cache, defer and/or optimize #567
Open
@floryst floryst mentioned this pull request Jun 27, 2024
Open
@floryst floryst force-pushed the streaming-base branch 2 times, most recently from 617a675 to 0bfe9d2 Compare August 1, 2024 19:06
floryst and others added 20 commits August 7, 2024 20:41
@floryst
refactor(dataSource): rename to FileDataSource
29ff074 
Fix an incorrect impl of the PartialWithRequired type
@floryst
feat(streaming): open URIs as streams
163290a 
- Detect mimetype of URI streams
- Download any unhandled streams as files
- Add onCleanup() hook to pipelines
@floryst
feat(streaming): add DICOM stream handler
ccc0625
@floryst
feat(streaming): add streaming integration
e54adc6
@floryst
fix(streaming): improved interface
aa2f36b 
Fixes some bugs regarding the order of chunk status updates.
@floryst
perf(windowing): perform histogram in worker
159424a
@floryst
fix(VolumeRendering): defer editor loading
f3d82d0 
Patches the opacity editor to not re-compute the data range
unnecessarily.
@floryst
chore: pin patched packages
c9c2f55
@floryst
chore(vtk.js): update to 30.9.0
816d2cc
@floryst
chore(vtk.js): apply streaming-textures patch
f2a7f30 
This should be removed in favor of updating vtk.js.
@floryst
feat: incremental volume loading
4c8fa15
@floryst
fix(MeasurementsToolList): ts error
40f5d1f
@floryst
chore: update package-lock
18b62b0
@floryst
fix(updateUriType): finished stream -> empty mime
000791b
@PaulHax @floryst
fix(DataBrowser): remove keys from panels to avoid error
95422cd
@floryst
fix(CachedStreamFetcher): better 404 error msg
02d5dba
@floryst
fix(allocateImageFromChunks): support 1-bit images
ca6afd5
@floryst
fix(vtk.js): incorrect patch
b7b0094
@floryst
fix(cachedStreamFetcher): handle Content-Range
1b953a0 
Support handling content-range headers if exposed. If not, then
content-range is inferred based on the content-length headers.
@floryst
fix(allocateImageFromChunks): support multi-frame
19e8af5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulHax PaulHax PaulHax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image range and histogram computation: cache, defer and/or optimize
2 participants
@floryst @PaulHax