Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github broke the UI again #49

Open
MrNaif2018 opened this issue Mar 17, 2022 · 10 comments
Open

Github broke the UI again #49

MrNaif2018 opened this issue Mar 17, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@MrNaif2018
Copy link

Description

Today I opened the repository page, and it got stretched in an unnatural way. Reproducable both in chrome and firefox

Screenshot

изображение
изображение

Other information

@MrNaif2018 MrNaif2018 added the bug Something isn't working label Mar 17, 2022
@Kir-Antipov
Copy link
Owner

Oh no, why does everything have to break during the goddamn war?

Can confirm, but I don't have any mental capacity to work on something at the moment, so pr will be really appreciated

@MrNaif2018
Copy link
Author

Yeah, I can totally understand you ):
I may try to check it, is it somewhere near https://github.com/Kir-Antipov/GitHub-Defreshed/blob/master/src/fixers/repository/columns-fixer.ts?

@Kir-Antipov
Copy link
Owner

I think it's more about ContainerFixer

@medievil1
Copy link

medievil1 commented Mar 19, 2022

PR, issue pages are normal width, so likely github made a change to allow the front page to use full resolution width instead of a fixed scalable size.. using browser zoom - side only shrinks the font, the page container does not change... it looks a bit weird, BUT everything is where it is supposed to be. just text is dangerously close to the edge on the left and could get cut off

@MrNaif2018
Copy link
Author

To update: even with #50 (using it for a while now, thanks @An-dz), today when loading repository page, then clicking for example pull requests button and then home button again, the UI is a bit broken once again

изображение

@An-dz
Copy link
Contributor

An-dz commented Apr 22, 2022

@MrNaif2018 What do you mean by "Home button"?

@MrNaif2018
Copy link
Author

I meant code button to return to repository's main page, sorry

@An-dz
Copy link
Contributor

An-dz commented Apr 30, 2022

Managed to reproduce now, but won't be able to fix it anytime soon.

@medievil1
Copy link

it is broken again unfortunately
image

@Kir-Antipov
Copy link
Owner

Yeah, it's been broken for quite a while now. Sadly, as a single maintainer, I cannot keep up with all the updates that are constantly being pushed by GitHub. While many of them are subtle and often don't even change anything visually, they do alter the layout and class names I relied on to make this project work.

Don't get me wrong, I still dislike the "refreshed" UI; not because of the round buttons and stuff, but because it's simply less practical than the original UI. However, I've decided to accept defeat. Pouring as much time and effort into this project, as it needs to continue functioning, is even more impractical than just dealing with the new UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants