Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Fix import issue in mod files #6

Closed
29 tasks done
CalvinWilkinson opened this issue Oct 14, 2023 · 0 comments · Fixed by #7
Closed
29 tasks done

🚧Fix import issue in mod files #6

CalvinWilkinson opened this issue Oct 14, 2023 · 0 comments · Fixed by #7
Assignees
@CalvinWilkinson
Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview
Milestone
v1.0.0-preview.3

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 14, 2023 •
edited
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Fix all of the mod.ts files in the project to use relative paths instead of the import maps.

This is causing issues when consuming the library as a user.

Also, replace all of the uses of Deno.exit(1) in the clients and other areas with proper replacement code.

Acceptance Criteria

  • All mod.ts files fixed
  • Remove all Deno.exit(1) uses
  • Following clients refactored to return or throw errors instead of print and exit
    • GitHub Clients
      • GitClient.ts
      • IssueClient.ts
      • LabelClient.ts
      • MilestoneClient.ts
      • OrgClient.ts
      • ProjectClient.ts
      • PullRequestClient.ts
      • ReleaseClient.ts
      • RepoClient.ts
      • TagClient.ts
      • UsersClient.ts
      • WorkflowClient.ts
  • Others
    • XClient.ts
    • NuGetClient.ts
  • Make the GitHubClient ctor params with the names ownerName and repoName required
  • Perform simple cleanup
    • Replace all !== with !=
  • Remove all uses of github action related messages
    • Remove functions from Utils.ts

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct milestone (if applicable).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview 🐛bug Something isn't working labels Oct 14, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.3 milestone Oct 14, 2023
@CalvinWilkinson CalvinWilkinson self-assigned this Oct 14, 2023
CalvinWilkinson added a commit that referenced this issue Oct 14, 2023
@CalvinWilkinson
Start work for issue #6
82a640b
@CalvinWilkinson CalvinWilkinson mentioned this issue Oct 14, 2023
Merged
1 task
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
0fdf798 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
2abcd48 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
32b00b7 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
c4f0261 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
4425e63 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
3cb185a 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
CalvinWilkinson added a commit that referenced this issue Nov 4, 2023
@CalvinWilkinson
🚧Fix import issue in mod files (#7)
a8face4 
* Start work for issue #6

* refactor: update the import paths to relative paths

* config: remove import maps

* refactor: update all import paths to relative paths

* config: setup external dependencies file

* cleanup: cleanup code using deno fmt

* ci: update deno check script to ignore certain directories

* ide: setup launch config for deno check script

* config: update deno lock file

* config: remove vendored dependencies

* config: update deno lock

* config: add git ignore for node_modules folder

* refactor: update deps imports

* ide: ignore node_modules folder

* ci: update unit test status check with permission

* deps: add dependency to npm chalk library

* ci: add ignore folder to deno check script

* chore: change what kind of message print error util func does

* refactor: improve error handling code in OrgClient

* refactor: improve error handling code in GitClient

* refactor: improve error handling in GraphQlClient

* refactor: improve error handling in IssueClient

* refactor: improve error handling in LabelClient

* refactor: improve error handling in RepoClient

* chore: fix error in utils function

* fix: add missing arguments

* ide: add permission to task

* refactor: improve error handling in GitHubClient

* config: improve dependencies

* config: update deno lock

* config: remove include and exclude for tests

* ci: update test status check to be explicit with tests

* chore: make functions public

* test: create tests for RepoClient

* refactor: improve error handling in MilestoneClient

* cleanup: remove unused protected funcs

* chore: setup launch config and playground with default args

* refactor: improve error handling in ProjectClient

* ci: improve deno check process

* refactor: improve error handling with PullRequestClient

* refactor: refactor param names across code base

* refactor: improve error handling with the ReleaseClient

* refactor: improve error handling of the TagClient

* refactor: improve error handling of the UsersClient

* fix: fix guards

* refactor: improve error handling in WorkflowClient

* ide: remove recommended extension

* refactor: improve error handling in XClient

* refactor: improve error handling of the NuGetClient

* refactor: further improve error handling of clients

* refactor: force ctor params to be required

* refactor: adjust not equals operators

* chore: remove utils function

* refactor: remove deno exit func from error handling code

* refactor: convert Guard functions to throw errors instead of exiting

* config: update version from v1.0.0-preview.2 to v1.0.0-preview.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinWilkinson CalvinWilkinson

Labels
🐛bug Something isn't working high-priority High Priority preview Done while in preview
Projects
None yet
Milestone
v1.0.0-preview.3
Development

Successfully merging a pull request may close this issue.

🚧Fix import issue in mod files KinsonDigital/kd_clients
1 participant
@CalvinWilkinson