Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Convert all models to interfaces #59

Merged
merged 2 commits into from
May 15, 2024

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented May 15, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #55

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Convert all models to interfaces May 15, 2024
@CalvinWilkinson CalvinWilkinson added medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction labels May 15, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this May 15, 2024
@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review May 15, 2024 08:48
@CalvinWilkinson CalvinWilkinson merged commit b3808f5 into preview May 15, 2024
5 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/55-convert-models-to-interfaces branch May 15, 2024 08:49
@CalvinWilkinson
Copy link
Member Author

Warning

Introduced the following https://github.com/KinsonDigital/kd_clients/labels/%F0%9F%A7%A8breaking%20changes

  1. The following model types have all been converted to interfaces:
    • CommitModel.ts
    • FileContentModel.ts
    • GitHubVariablesModel.ts
    • GitHubVarModel.ts
    • IssueModel.ts
    • LabelModel.ts
    • MilestoneModel.ts
    • ProjectModel.ts
    • PullRequestHeadOrBaseModel.ts
    • PullRequestInfoModel.ts
    • PullRequestModel.ts
    • ReleaseModel.ts
    • RepoModel.ts
    • TagModel.ts
    • UserModel.ts
    • WorkflowRunModel.ts
    • WorkflowRunsModel.ts
    • ErrorModel.ts
    • GitBranchModel.ts
    • GraphQIRequestResponseModel.ts
    • LocationModel.ts
    • PagelnfoModel.ts
    • RawGetBranchTargetModel.ts
    • RawGitBranchModel.ts
    • RawRefsGetBranchModel.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Convert all models to interfaces
2 participants