Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add upload asset feature to release client #23

Merged
merged 14 commits into from
Dec 7, 2023

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Dec 7, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #22

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson self-assigned this Dec 7, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.6 milestone Dec 7, 2023
@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Add upload asset feature to release client Dec 7, 2023
@CalvinWilkinson CalvinWilkinson added preview Done while in preview ✨new-feature New feature that does not exist labels Dec 7, 2023
@CalvinWilkinson CalvinWilkinson added the 🧨breaking-changes Feature/changes contains breaking changes label Dec 7, 2023
@CalvinWilkinson
Copy link
Member Author

Warning
Introduced https://github.com/KinsonDigital/kd_clients/labels/%F0%9F%A7%A8breaking%20changes

  1. Removed the function getReleaseByTag from the ReleaseClient. This has been replaced by the new getRelease function
  2. Removed the function getReleaseByName from the ReleaseClient. This has been replaced by the new getRelease function

@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review December 7, 2023 16:33
@CalvinWilkinson CalvinWilkinson merged commit d673bb0 into preview Dec 7, 2023
5 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/22-upload-release-asset branch December 7, 2023 16:56
@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented Dec 7, 2023

Note
Added https://github.com/KinsonDigital/kd_clients/labels/%E2%9C%A8new%20feature 's:

  1. Add a new function to the ReleaseClient class with the name uploadAssets to upload one or more assets to a releease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes ✨new-feature New feature that does not exist preview Done while in preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Add upload asset feature to release client
2 participants