Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Update clients to check for authentication issues #10

Merged
merged 54 commits into from
May 14, 2024

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Nov 10, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #9

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson self-assigned this Nov 10, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.4 milestone Nov 10, 2023
@CalvinWilkinson CalvinWilkinson changed the title auth 🚧Update clients to check for authentication issues Nov 10, 2023
@CalvinWilkinson CalvinWilkinson added medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction ✨new-feature New feature that does not exist labels Nov 10, 2023
@CalvinWilkinson CalvinWilkinson added the 🧨breaking-changes Feature/changes contains breaking changes label May 12, 2024
@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented May 12, 2024

Warning

Introduced the following https://github.com/KinsonDigital/kd_clients/labels/%F0%9F%A7%A8breaking%20changes

  1. Changed the name of the 'getByValue' parameter to tagOrTitle for the getRelease() function in the ReleaseClient class.
  2. Changed the name of the 'toReleaseBy' parameter to tagOrTitle for the uploadAssets() function in the ReleaseClient class.
  3. Moved the XError type from the GitHubClients.Errors.mod.ts file to the OtherClients.Errors.mod.ts file.
  4. Moved the NuGetError type from the GitHubClients.Errors.mod.ts file to the PackageClients.Errors.mod.ts file.
  5. Refactored the getPullRequests() function return type from Promise<[PullRequestModel[], Response]> to Promise<PullRequestModel[]> in the PullRequestClient class.
  6. Refactored the getIssues() function return type from Promise<[IssueModel[], Response]> to Promise<IssueModel[]> in the IssueClient class.
  7. Refactored the getOwnerRepos() function return type from Promise<[RepoModel[], Response]> to Promise<RepoModel[]> in the RepoClient class.
  8. Changed the name of the getOwnerRepos() function to getAllRepos().
  9. Refactored the getTags() function return type from Promise<[TagModel[], Response]> to Promise<TagModel[]> in the TagClient class.
  10. Refactored the getWorkflowRuns() function return type from Promise<[WorkflowRunModel[], Response]> to Promise<WorkflowRunModel[]> in the WorkflowClient class.

@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review May 14, 2024 09:48
@CalvinWilkinson CalvinWilkinson changed the base branch from main to preview May 14, 2024 09:51
@CalvinWilkinson CalvinWilkinson merged commit 38efe6f into preview May 14, 2024
5 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/9-update-client-auth branch May 14, 2024 10:14
@CalvinWilkinson CalvinWilkinson added preview Done while in preview and removed 🐛bug Something isn't working labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes 💎enhancement An improvement on something medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Update clients to check for authentication issues
2 participants