Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Change CornerRadius param order #966

Open
3 of 7 tasks
CalvinWilkinson opened this issue May 8, 2024 · 0 comments
Open
3 of 7 tasks

🚧Change CornerRadius param order #966

CalvinWilkinson opened this issue May 8, 2024 · 0 comments
Assignees
Labels
🧨breaking-changes Feature/changes contains breaking changes medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented May 8, 2024

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Change the order of the parameters for the constructor for the CornerRadius struct.

Currently, the parameters set the radius of each corner in a counter-clockwise order. This is not as intuitive. Most people naturally gravitate towards clockwise order.

Current Order:

  1. TopLeft
  2. BottomLeft
  3. BottomRight
  4. TopRight

Change To:

  1. TopLeft
  2. TopRight
  3. BottomRight
  4. BottomLeft

Also, verify that all other uses of struct internally within Velaptor take this into account so we avoid any bugs.

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

ToDo Items

The items to complete to satisfy the Definition of Done.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority 🧨breaking-changes Feature/changes contains breaking changes labels May 8, 2024
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.37 milestone May 8, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Status: 🏗️In Development
Development

No branches or pull requests

1 participant