Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Meeting Reminders v14+ Build and Bug fix #139

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nateh777
Copy link
Member

@nateh777 nateh777 commented Oct 5, 2023

Description

What does the change add or fix?

Update version to rebuild for v14+ with new iCal reference and found a bug that it was not actually honoring no/false on the attribute.


Release Notes

What does the change add or fix in a succinct statement that will be read by clients?

Requested By

Who reported, requested, or paid for the change?

Warranty


Screenshots

Does this update or add options to the block UI?

No


Change Log

What files does it affect?
  • rocks.kfs.CustomGroupCommunication/Jobs/MeetingGroupReminder.cs
  • rocks.kfs.CustomGroupCommunication/Properties/AssemblyInfo.cs

Migrations/External Impacts

Is it a breaking change for other versions/clients?

Yes, technically 14+ only will have the fix for the boolean "no/false" and has to have a specific dll build for version support.

@nateh777 nateh777 self-assigned this Oct 5, 2023
@nateh777 nateh777 requested a review from guymaness2 October 5, 2023 18:25
@nateh777 nateh777 linked an issue Oct 5, 2023 that may be closed by this pull request
@guymaness2 guymaness2 merged commit e51fc8e into hotfix-14 Oct 17, 2023
@guymaness2 guymaness2 deleted the bug/nbh-GroupMeetingReminder-14 branch October 17, 2023 16:59
nateh777 pushed a commit that referenced this pull request Oct 17, 2023
…r-14

Group Meeting Reminders v14+ Build and Bug fix

(cherry picked from commit e51fc8e)
@nateh777 nateh777 added the Team Review Code to be shown to team. label Oct 24, 2023
@carlatKFS carlatKFS removed the Team Review Code to be shown to team. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B: Group Communication/Custom Group Reminder Emails Exception
3 participants