Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to reproduce the original paper effect #20

Open
SEMLLYCAT opened this issue Feb 13, 2023 · 2 comments
Open

Unable to reproduce the original paper effect #20

SEMLLYCAT opened this issue Feb 13, 2023 · 2 comments

Comments

@SEMLLYCAT
Copy link

SEMLLYCAT commented Feb 13, 2023

Thank you for your work.
Hello, I tried to use your source code to train HDemucs, adopted 8 3090s, the parameters did not change, and trained 360 epochs. The test results are as follows:
Test/nsdr: 5.5024
Test/nsrd_bass:5.4150
Test/nsrd_drums: 6.2600
Test/nsdr_other: 3.5410
Test/nsrd_vocals: 6.7935
paper result:
Test/nsdr: 7.68
Test/nsrd_bass:6.06
Test/nsrd_drums: 8.24
Test/nsdr_other: 5.59
Test/nsrd_vocals: 8.13
I would like to ask you whether you have reproduced the original close result, whether there are other points I did not notice, whether 360epoch is not enough. Maybe I should change monitor loss to nsdr

@KinWaiCheuk
Copy link
Owner

Sorry for the late reply. We are also unable to reproduce the same result as reported in the paper.

@turian
Copy link
Collaborator

turian commented May 3, 2023

Not saying this will fix everything but
a) I think you should be monitoring NSDR
b) HTDemucs (and maybe HDemucs) use EMA, if I'm not mistaken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants