-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the size of integer used for the kernel attributes #450
Comments
FYI @gmlueck |
I certainly think that the attributes should accept any integer value that can be represented in a I suppose the behavior for even larger values is debatable. One option is to allow any C++ integer literal. At runtime the implementation would see if the device supports the requested work-group / sub-group size. This would almost certainly be "no" for any value that is larger than Were you asking about values that are no bigger than |
Just the case where values that can fit in I didn't think about that weird case, but from that cppreference page, it says that literals that can't fit inside any integer type make the program ill-formed, so I don't think that's an issue. |
Yes, but there could be integer types that are larger than |
I don't think that we should consider integer types which are larger than
|
Yes, I think that makes sense too. We should change the spec wording from:
To:
Except for
This is because the APIs for sub-group size all return |
Max number of sub-groups in a work-group is defined as |
The |
Oh, I see. Should we also consider updating |
For kernel attributes like
reqd_work_group_size
,reqd_sub_group_size
, what integer size is used for the argument? I assume sincerange
usesize_t
, the types should besize_t
.The text was updated successfully, but these errors were encountered: