Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event::wait_and_throw only mentions async handler of context #299

Open
steffenlarsen opened this issue Oct 17, 2022 · 2 comments · May be fixed by #720
Open

event::wait_and_throw only mentions async handler of context #299

steffenlarsen opened this issue Oct 17, 2022 · 2 comments · May be fixed by #720
Assignees
@psalz
Labels
CTS May require changes to CTS Waiting for PR

Comments

@steffenlarsen
Copy link
Contributor

steffenlarsen commented Oct 17, 2022 •
edited
Loading

The specification states that for event::wait_and_throw that;

Any unconsumed asynchronous errors from any context that the event was waiting on executions from will be passed to the async_handler associated with the context. If no user defined async_handler is associated with the context, then an implementation-defined default async_handler is called to handle any errors, as described in Section 4.13.1.2.

In this it only mentions the contexts of associated events. However, Section 4.13.1.3 states that async handlers of queues should have higher priority than those on contexts, if the runtime can make the association.

Should event::wait_and_throw use similar wording to that used in queue::wait_and_throw? That is;

Any unconsumed asynchronous errors will be passed to the async_handler associated with the queue or enclosing context. If no user defined async_handler is associated with the queue or enclosing context, then an implementation-defined default async_handler is called to handle any errors, as described in Section 4.13.1.2.
steffenlarsen added a commit to steffenlarsen/SYCL-CTS that referenced this issue Oct 17, 2022
@steffenlarsen
Change event::wait_and_throw test case
8b9d8b2 
One of the event::wait_and_throw test cases makes the assumption that
queue async handlers are somehow propagated to contexts. However,
according to [Section 4.13.1.3](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#_priorities_of_async_handlers)
there are priorities to which async handlers are to be used, where
queue is the highest, assuming the runtime can make the association
between events and queues. This commit changes the test to follow the
aforementioned section, assuming the queues are associated with the
events. See also KhronosGroup/SYCL-Docs#299.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen mentioned this issue Oct 17, 2022
Merged
@gmlueck
Copy link
Contributor

gmlueck commented Oct 18, 2022

In order to avoid duplication, could we word the description of both event::wait_and_throw and queue::wait_and_throw to say something like:

Any unconsumed asynchronous errors will be passed to the async_handler as described in Section 4.13.1.2.

@psalz psalz added the CTS May require changes to CTS label Oct 24, 2022
@tomdeakin
Copy link
Contributor

11/10 Waiting for draft PR.

@Pennycook Pennycook linked a pull request Feb 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psalz psalz

Labels
CTS May require changes to CTS Waiting for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align wait_and_throw from queue:: and event:: Pennycook/SYCL-Docs
4 participants
@psalz @tomdeakin @gmlueck @steffenlarsen