SPIR-V 1.4 Testing

[bashbaug]

This issue is intended to track testing for SPIR-V 1.4 features.

• New Decoration:
  • UserSemantic - add SPIR-V 1.4 testing for UserSemantic #2053
• New-ish Decorations (also supported by SPV_KHR_no_integer_wrap_decoration):
  • NoSignedWrap - add SPIR-V 1.4 testing for no integer wrap decorations #2041
  • NoUnsignedWrap - add SPIR-V 1.4 testing for no integer wrap decorations #2041
• New Image Operands:
  • SignExtend - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
  • ZeroExtend - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
• New Loop Controls:
  • MinIterations - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
  • MaxIterations - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
  • IterationMultiple - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
  • PeelCount - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
  • PartialCount - add SPIR-V 1.4 testing for Image Operands and Loop Controls #2034
• New OpSpecConstantOp? May actually not be new.
  • OpUConvert - cover as part of Missing Testing for OpSpecConstantOp #2137
• New Instructions:
  • OpDecorateString - add SPIR-V 1.4 testing for UserSemantic #2053
  • OpMemberDecorateString - add SPIR-V 1.4 testing for UserSemantic #2053
  • OpPtrEqual - add SPIR-V 1.4 testing for OpPtrEqual, OpPtrNotEqual, OpPtrDiff #2054
  • OpPtrNotEqual - add SPIR-V 1.4 testing for OpPtrEqual, OpPtrNotEqual, OpPtrDiff #2054
  • OpPtrDiff - add SPIR-V 1.4 testing for OpPtrEqual, OpPtrNotEqual, OpPtrDiff #2054
  • OpCopyLogical - add SPIR-V 1.4 testing for OpCopyLogical #2136
• New Behavior:
  • NonWritable decoration can apply to objects in the Function storage class. - add SPIR-V 1.4 testing for various miscellaneous additions #2122
  • OpCopyMemory can take two optional memory operands. - add SPIR-V 1.4 testing for various miscellaneous additions #2122
  • OpCopyMemorySized can also take two optional memory operands. - add SPIR-V 1.4 testing for various miscellaneous additions #2122
  • OpSelect supports non-vector composite types. - add SPIR-V 1.4 testing for various miscellaneous additions #2122

[bashbaug]

Testing for OpCopyMemory with two optional memory operands is on hold due to issues in the SPIR-V LLVM Translator, see KhronosGroup/SPIRV-LLVM-Translator#2769.

[bashbaug]

Testing OpCopyLogical is on hold due to issues in the SPIR-V LLVM Translator, see KhronosGroup/SPIRV-LLVM-Translator#2768.

[bashbaug]

Regarding the last item without a PR - OpSpecConstantOp support for OpUConvert - here are several possible options:

1. I can add a targeted test for just OpUConvert.
2. We can ensure this case gets tested as part of the resolution for Missing Testing for OpSpecConstantOp #2137.

[svenvh]

Regarding the last item without a PR - OpSpecConstantOp support for OpUConvert - here are several possible options:

1. I can add a targeted test for just OpUConvert.
2. We can ensure this case gets tested as part of the resolution for Missing Testing for OpSpecConstantOp #2137.

This isn't new functionality in "Kernel-flavour" SPIR-V 1.4 it seems. The SPIR-V specification says this for OpSpecConstantOp:

If the Kernel capability was declared, the following opcodes are also valid: ..., OpUConvert,

OpUConvert support for OpSpecConstantOp seems only new in SPIR-V 1.4 for graphics, also confirmed by the internal Khronos SPIR-V Issue 156.

So option 2 from your list sounds reasonable to me.

[bashbaug]

Cool, I think all tasks are complete then, so I am closing this issue.