Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostname_col not used for grouping in sheet_to_inventory() #10

Open
BenoitCattie opened this issue May 20, 2019 · 2 comments
Open

hostname_col not used for grouping in sheet_to_inventory() #10

BenoitCattie opened this issue May 20, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@BenoitCattie
Copy link

Hello,

i think in the sheet_to_inventory(), the grouping is assuming that hostname is in column '0' :
groups['_meta']['hostvars'][row[0].value][var_name.value.lower().replace(' ', '_')] = row[idx].value

I think it should be

groups['_meta']['hostvars'][row[hostname_col].value][var_name.value.lower().replace(' ', '_')] = row[idx].value

Benoit

@KeyboardInterrupt KeyboardInterrupt self-assigned this Aug 5, 2019
@KeyboardInterrupt
Copy link
Owner

Sorry for the late reply, I will look into this, not right away, but eventually!
Thank you for letting me know.

@diepes
Copy link

diepes commented Sep 21, 2020

Created PR to fix this #15

@KeyboardInterrupt KeyboardInterrupt added the bug Something isn't working label Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants