Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache entry with key with vary headers isn't deleted #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janalwin
Copy link

@janalwin janalwin commented Jul 5, 2022

Two cache entries are created when the response has vary headers. But when you call delete, only the entry without the vary headers in the cache key is deleted.
When you do a new call directly after deletion everything is ok. The cache entry without vary info is created again and returned. But if you use the Laravel backend, the cache entry with vary info won't be updated. (a If you repeat the call, the old cache entry with the vary info will be returned and not de fresh cache entry.

To fix this problem, we now delete both entries in the delete method.

@Kevinrob
Copy link
Owner

Kevinrob commented Nov 5, 2023

Can you write some tests for this use-case and rebase your branch from master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants