Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar uneven spacing when positionGlobalFilter is left #436

Closed
1 task done
ishchhabra opened this issue Nov 5, 2024 · 0 comments · Fixed by #456
Closed
1 task done

Search bar uneven spacing when positionGlobalFilter is left #436

ishchhabra opened this issue Nov 5, 2024 · 0 comments · Fixed by #456
Labels
bug Something isn't working V2 Issue with MRT V2

Comments

@ishchhabra
Copy link

mantine-react-table version

2.0.0-beta.7

react & react-dom versions

18.3.1

Describe the bug and the steps to reproduce it

Description

When positionGlobalFilter is set to "left", the search bar displays uneven spacing between the top and left edges due to an additional mx="sm" margin being applied at

Overriding mantineSearchTextInputProps with mx: 0 solves this, but this seems like something that could be fixed as part of the library by using different mx values based on the positionGlobalFilter.

Minimal, Reproducible Example - (Optional, but Recommended)

The bug should be reproducible by simply rendering a table with positionGlobalFilter: "left". If needed, happy to provide a complete reproducible example.

Screenshots or Videos (Optional)

image

Do you intend to try to help solve this bug with your own PR?

Yes, I think I know how to fix it and will discuss it in the comments of this issue

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@alessandrojcm alessandrojcm added bug Something isn't working V2 Issue with MRT V2 labels Dec 10, 2024
@alessandrojcm alessandrojcm linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V2 Issue with MRT V2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants