-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 MRT exports all @tabler/react-icons
during dev mode
#418
Comments
This is just during dev mode without any tree shaking though, right? |
Yeah seems to be only in dev mode. I will update the title |
@tabler/react-icons
@tabler/react-icons
during dev mode
Most likely going to close this since it's expected. |
Anyway to solve this issue? It takes 10-15 seconds to load simple table when dev tools is open. I always use dev tools open so it's really making it harder to use it. It affects development experience a lot. I've tried to merge chunks in vite but couldn't find a way to do that in development mode. I really like this library but because of this issue I cannot use it. |
After hours of debugging, I found that downgrade @tabler/icons-react |
Yeah it's an issue with the icon library - tabler/tabler-icons#1233 |
Yeah, on further looking into that issue, it's not great. I guess a brute force solution would be to just copy the raw icon svgs into the MRT source code and remove tabler icons as a peer dep. Hopefully they just ship a fix though. |
I will close this as it is an issue with Tabler and it's only in dev mode. Feel free to reopen if this changes. |
mantine-react-table version
2.0.0-beta.6
react & react-dom versions
18.3.0
Describe the bug and the steps to reproduce it
When working with
v2
MRT, the Network tab in devtools is having performance issues because for each tabler icons we get a chunk request thus producing over 5700 requests.FYI I'm not using any tabler icons in that repo.
Minimal, Reproducible Example - (Optional, but Recommended)
<LibrariesList />
(or inLibrariesList
component, comment out any code related to MRT)Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
No, because I do not have time to dig into it
Terms
The text was updated successfully, but these errors were encountered: