Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time detection / parsing (yearly salary) #96

Open
tchaflich opened this issue Jan 16, 2022 · 0 comments
Open

Time detection / parsing (yearly salary) #96

tchaflich opened this issue Jan 16, 2022 · 0 comments

Comments

@tchaflich
Copy link

One message that the bot reacted to:

image

I was wondering what it could have thought was a time in there (my best guess was "year"), but it responded with this:

image

had a base salary of $927,000 a year.

It detected the part of the salary after the comma, a space, and the letter "a" and interpreted that as midnight (I assume, since NL and US are six hours apart).

I would suggest that any commas that are part of a formatted numeric string (including currency signs, decimal points, commas, negative signs, and numeric characters) not be considered as a time.


It's also a side note, but 000 (a|p) both parse as valid times (noon and midnight). I don't know of any time format that represents time in quite this way. The mixture of three digits and meridian indicator doesn't seem to work for non-zero digits (for example, 111 a is not picked up by the bot as a valid time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant