From a1ba8bd3dab65d4213192918b8d4216330cb5a7e Mon Sep 17 00:00:00 2001
From: Vishwajith Shettigar
 <76042077+Vishwajith-Shettigar@users.noreply.github.com>
Date: Thu, 7 Sep 2023 18:06:05 +0530
Subject: [PATCH] Fix #5142 Edit text foreground and background contrast ratio
 issue in Light mode  (#5144)

## Explanation
Fix #5142, changed text input default stroke color.
Added color resource file names component_color_text_layout.xml in order
to give stroke color
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

Berore fix
| Light mode| Dark mode|
|--------|--------|
|
![contarstlight_before](https://github.com/oppia/oppia-android/assets/76042077/0fcb4613-a7fb-4320-ae88-792704d61950)|![contastdark_before](https://github.com/oppia/oppia-android/assets/76042077/d36c6c13-654a-4603-8cef-80472dacf0d3)|

Afterfix
| Light mode| Dark mode|
|--------|--------|

|![newnew](https://github.com/oppia/oppia-android/assets/76042077/ef50252b-7c21-41ab-baee-2f244e87644b)|![contrastdark_after](https://github.com/oppia/oppia-android/assets/76042077/e4418fb6-9fb1-4c32-8c54-339235303abb)|

Screen recording after fix

Light mode


https://github.com/oppia/oppia-android/assets/76042077/943629a3-2b4a-4459-bbf9-0f0246860ffd

Dark mode


https://github.com/oppia/oppia-android/assets/76042077/c85256a0-5f99-4577-82e4-b95ce0d24027



<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
---
 app/src/main/res/color/component_color_text_layout.xml | 5 +++++
 app/src/main/res/values-night/color_palette.xml        | 2 ++
 app/src/main/res/values/color_palette.xml              | 2 ++
 app/src/main/res/values/styles.xml                     | 2 +-
 4 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 app/src/main/res/color/component_color_text_layout.xml

diff --git a/app/src/main/res/color/component_color_text_layout.xml b/app/src/main/res/color/component_color_text_layout.xml
new file mode 100644
index 00000000000..9795672d6eb
--- /dev/null
+++ b/app/src/main/res/color/component_color_text_layout.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+  <item android:color="@color/color_palette_edit_text_inactive_color" android:state_focused="false"/>
+  <item android:color="@color/color_palette_edit_text_active_color" android:state_focused="true"/>
+</selector>
diff --git a/app/src/main/res/values-night/color_palette.xml b/app/src/main/res/values-night/color_palette.xml
index 7bb64f94cb7..299d498bfc6 100644
--- a/app/src/main/res/values-night/color_palette.xml
+++ b/app/src/main/res/values-night/color_palette.xml
@@ -225,4 +225,6 @@
   <color name="color_palette_nps_selected_text_color">@color/color_def_white</color>
   <color name="color_palette_nps_selected_background_color">@color/color_def_oppia_green</color>
   <color name="color_palette_nps_unselected_background_color">@color/color_def_pale_green</color>
+  <color name="color_palette_edit_text_inactive_color">@color/color_def_black_87</color>
+  <color name="color_palette_edit_text_active_color">@color/color_def_white</color>
 </resources>
diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml
index 50e8f6caa30..13113daf937 100644
--- a/app/src/main/res/values/color_palette.xml
+++ b/app/src/main/res/values/color_palette.xml
@@ -265,4 +265,6 @@
   <color name="color_palette_survey_disabled_button_text_color">@color/color_def_chooser_grey</color>
   <color name="color_palette_button_text_color">@color/color_def_persian_green</color>
   <color name="color_palette_edit_text_unselected_color">@color/color_def_grey</color>
+  <color name="color_palette_edit_text_inactive_color">@color/color_def_black_87</color>
+  <color name="color_palette_edit_text_active_color">@color/color_def_black_87</color>
 </resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 2be703def67..149d87fd1d1 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -170,7 +170,7 @@
     <item name="boxCornerRadiusBottomStart">@dimen/text_input_layout_corner_radius</item>
     <item name="boxCornerRadiusTopEnd">@dimen/text_input_layout_corner_radius</item>
     <item name="boxCornerRadiusTopStart">@dimen/text_input_layout_corner_radius</item>
-    <item name="boxStrokeColor">@color/component_color_shared_text_input_layout_stroke_color</item>
+    <item name="boxStrokeColor">@color/component_color_text_layout</item>
     <item name="boxStrokeWidth">@dimen/text_input_layout_stroke_width</item>
     <item name="errorEnabled">true</item>
     <item name="errorIconTint">@color/component_color_shared_text_input_layout_error_color</item>