Skip to content

Commit b24e129

Browse files
committed
Add support for PyroEnvironment and fix a few bugs
1 parent 2dfac53 commit b24e129

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

BeatSaberCinema/Environment/EnvironmentController.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,6 @@ private static void DefaultSceneModifications(VideoConfig? videoConfig)
321321
{
322322
Log.Warn("BTS movement effect not found");
323323
}
324-
325-
if (videoConfig!.screenPosition == null)
326-
{
327-
var placement = Placement.GetDefaultPlacementForScene(PlaybackController.Scene.SoloGameplay);
328-
placement.Position.z = 80;
329-
PlaybackController.Instance.VideoPlayer.SetPlacement(placement);
330-
}
331-
332324
break;
333325
}
334326
case "OriginsEnvironment":

BeatSaberCinema/HarmonyPatches/EnvironmentOverridePatch.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ public static void Prefix(IDifficultyBeatmap difficultyBeatmap, ref OverrideEnvi
7272
"MonstercatEnvironment",
7373
"CrabRaveEnvironment",
7474
"SkrillexEnvironment",
75-
"WeaveEnvironment"
75+
"WeaveEnvironment",
76+
"PyroEnvironment"
7677
};
7778

7879
var mapEnvironmentInfoSo = difficultyBeatmap.GetEnvironmentInfo();

BeatSaberCinema/Screen/Placement.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ public static Placement CreatePlacementForConfig(VideoConfig? config, PlaybackCo
6060
);
6161

6262
placement.Width = placement.Height * aspectRatio;
63-
placement.Curvature = config?.screenCurvature;
64-
placement.Subsurfaces = config?.screenSubsurfaces;
65-
placement.CurveYAxis = config?.curveYAxis;
63+
placement.Curvature = config.screenCurvature ?? defaultPlacement.Curvature;
64+
placement.Subsurfaces = config.screenSubsurfaces;
65+
placement.CurveYAxis = config.curveYAxis;
6666

6767
return placement;
6868
}
@@ -90,6 +90,7 @@ public static Placement GetDefaultPlacementForScene(PlaybackController.Scene sce
9090
"MonstercatEnvironment" => new Placement(new Vector3(0f, 5.46f, 40f), new Vector3(-5f, 0f, 0f), 13f),
9191
"SkrillexEnvironment" => new Placement(new Vector3(0f, 1.5f, 30f), Vector3.zero, 12f),
9292
"WeaveEnvironment" => new Placement(new Vector3(0f, 1.5f, 21f), Vector3.zero, 4.3f, null, 0f),
93+
"PyroEnvironment" => new Placement(new Vector3(0f, 12f, 60f), Vector3.zero, 24f, null, 0f),
9394
_ => null
9495
};
9596
}

BeatSaberCinema/Video/VideoConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ [JsonIgnore] public string? VideoPath
8080
[JsonIgnore] public bool IsPlayable => (DownloadState == DownloadState.Downloaded || IsStreamable) && !PlaybackDisabledByMissingSuggestion;
8181
[JsonIgnore] public bool IsWIPLevel => LevelDir != null && LevelDir.Contains(VideoLoader.WIP_DIRECTORY_NAME);
8282
[JsonIgnore] public bool EnvironmentModified => (environment != null && environment.Length > 0) || screenPosition != null || screenHeight != null;
83-
public float PlaybackSpeed => playbackSpeed ?? 1;
83+
[JsonIgnore] public float PlaybackSpeed => playbackSpeed ?? 1;
8484

8585

8686
private static Regex _regexParseID = new Regex(@"\/watch\?v=([a-z0-9_-]*)",

0 commit comments

Comments
 (0)