Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change GetArchives to return shared pointer to copy of vector #714

Open
briaguya-ai opened this issue Oct 24, 2024 · 0 comments
Open

change GetArchives to return shared pointer to copy of vector #714

briaguya-ai opened this issue Oct 24, 2024 · 0 comments
Milestone

Comments

@briaguya-ai
Copy link
Collaborator

std::vector<std::shared_ptr<Archive>> GetArchives();

follow pattern from

std::shared_ptr<std::vector<std::string>> ArchiveManager::ListFiles() {
auto list = std::make_shared<std::vector<std::string>>();
for (const auto& [hash, path] : mHashes) {
list->push_back(path);
}
return list;
}

@briaguya-ai briaguya-ai added this to the LUS 2.0.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant