Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make DidLoadSuccessfully protected instead of public #710

Open
briaguya-ai opened this issue Oct 24, 2024 · 0 comments
Open

make DidLoadSuccessfully protected instead of public #710

briaguya-ai opened this issue Oct 24, 2024 · 0 comments
Milestone
LUS 2.0.0

Comments

@briaguya-ai
Copy link
Collaborator

libultraship/src/resource/ResourceManager.h

Line 54 in 00c6bcc

bool DidLoadSuccessfully();

is only ever used in ResourceManager itself, i'd say make it private but protected gives us some wiggle room
@briaguya-ai briaguya-ai added this to the LUS 2.0.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
LUS 2.0.0
Development

No branches or pull requests
1 participant
@briaguya-ai