Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require Context to use Fast3dWindow. #577

Open
Kenix3 opened this issue May 9, 2024 · 1 comment
Open

Do not require Context to use Fast3dWindow. #577

Kenix3 opened this issue May 9, 2024 · 1 comment
Assignees
Milestone

Comments

@Kenix3
Copy link
Owner

Kenix3 commented May 9, 2024

How are we going to accomplish this since the Window is an abstract base class?
Basically the idea is to pass a Window in for the Context constructor, and the createInstance method.

@Kenix3 Kenix3 mentioned this issue May 9, 2024
4 tasks
@Kenix3 Kenix3 changed the title Do not require Context to use Fast3dWindow. How? Do not require Context to use Fast3dWindow. May 9, 2024
@Kenix3 Kenix3 added this to the LUS 2.0.0 milestone May 9, 2024
@briaguya-ai briaguya-ai self-assigned this Aug 2, 2024
@briaguya-ai
Copy link
Collaborator

void Context::InitWindow(std::vector<std::shared_ptr<GuiWindow>> guiWindows) {
if (GetWindow() != nullptr) {
return;
}
mWindow = std::make_shared<Fast::Fast3dWindow>(guiWindows);
GetWindow()->Init();
}

ports should do this and pass it into context instead of guiWindows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants