-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directory vs extension for samples #373
Comments
I'm neutral on this. But if playing around with it seems better, yeah I get that and sounds reasonable. |
This is intentional as otherwise there is no way to remove test cases (such as those in
Often you want to show different sample output than what's in the |
Having a
ok, so that is another use case. I still think it is more valuable to support both scenarios, which is only possible if statement files are not validated at all. Note that you can still validate the statement ans file by adding/symlinking it as What is the general opinion about extensions instead of directories? |
While implementing the spec for the new sample directories (
data/sample/statement/
anddata/sample/download/
) for BAPCtools I noticed a few quirks and potential pitfalls.For example the existence of
data/sample/download/
shadows all testcases (not only those for which a overwrite file is provided).Additionally the directory structure makes it more likely the directories get out of sync, i.e. a sample is only added/removed from one of the samples.
Also somehow the point of
data/sample/statement/
is missed? IMO this is only useful to present non validated input files (else it could just be a normal testcase?) so i explicitly want it to be not validated? (see the attached PR)I would propose to instead introduce the extensions
.statement
and.download
for this.For example
data/sample/x.in
would than be replaced bydata/sample/x.in.statement
for the problem statement.This approach has a few benefits:
data/sample/<x>
match the globdata/sample/<x>.*
The text was updated successfully, but these errors were encountered: