Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous 'DOMSubtreeModified' DOM Mutation Event is deprecated #768

Open
cancan101 opened this issue Oct 17, 2023 · 3 comments
Open

Synchronous 'DOMSubtreeModified' DOM Mutation Event is deprecated #768

cancan101 opened this issue Oct 17, 2023 · 3 comments

Comments

@cancan101
Copy link
Contributor

Similar issue to: #766 but in a totally different part of the code:

container.on("DOMSubtreeModified", center);

Seeing lots of these warnings:

Listener added for a synchronous 'DOMSubtreeModified' DOM Mutation Event. This event type is deprecated (https://w3c.github.io/uievents/#legacy-event-types) and work is underway to remove it from this browser. Usage of this event listener will cause performance issues today, and represents a risk of future incompatibility. Consider using MutationObserver instead.
@josteink
Copy link
Collaborator

Nice catch!

I was considering merging #767 today, but do you want to update the PR to also include fixes for that before I merge? 😄

@cancan101
Copy link
Contributor Author

No . Will do in it's own pr

@josteink
Copy link
Collaborator

OK. Let's make it so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants