Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction multi-signature validation looks not finished. #42

Open
R3VoLuT1OneR opened this issue Jan 3, 2022 · 1 comment
Open

Transaction multi-signature validation looks not finished. #42

R3VoLuT1OneR opened this issue Jan 3, 2022 · 1 comment

Comments

@R3VoLuT1OneR
Copy link
Contributor

Transaction multi-signature validation looks not finished.

Because output is not filled and has zero values condition on line 569 will be always true and validation always gonna fail.

if (outputKeyIndex == output.keys.size()) {

CryptoNote::MultisignatureOutput output;
size_t inputSignatureIndex = 0;
size_t outputKeyIndex = 0;
while (inputSignatureIndex < in.signatureCount) {
if (outputKeyIndex == output.keys.size()) {
m_validationResult.errorCode = CryptoNote::error::TransactionValidationError::INPUT_INVALID_SIGNATURES;
m_validationResult.errorMessage = "Transaction has input with invalid signature";
return false;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants