Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file driver cache hashing does not work #19

Open
Kuisaa opened this issue Dec 8, 2022 · 2 comments
Open

file driver cache hashing does not work #19

Kuisaa opened this issue Dec 8, 2022 · 2 comments

Comments

@Kuisaa
Copy link

Kuisaa commented Dec 8, 2022

If I use "file" cache driver the cache gets named [object Promise].cache and by awaiting the key hashing I get different key each time, so using get or has etc. will result in error, since the file named after the hashed key cannot exist.

@nautonk
Copy link

nautonk commented Jan 2, 2023

i'm facing this problem too, any solution ?

@shiny
Copy link

shiny commented May 6, 2023

  • Hash.make is a async method, but in FileCache.ts it called without a await
    private hashKey(key: string) {
        return this.hash.make(key + '')
    }
    
  • There is a lot of synchronous file API call
  • The testing was lacking

this file cache driver is not ready for production usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants