From fc44737a49ff0c78d5f10a0026a0125eaf0552e6 Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Sat, 13 Jul 2024 06:52:30 -0700 Subject: [PATCH] [commands] Suppress this-escape warnings (#6828) --- .../java/edu/wpi/first/wpilibj2/command/ConditionalCommand.java | 1 + .../main/java/edu/wpi/first/wpilibj2/command/PIDCommand.java | 1 + .../edu/wpi/first/wpilibj2/command/ParallelCommandGroup.java | 1 + .../edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java | 1 + .../java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java | 1 + .../java/edu/wpi/first/wpilibj2/command/ProfiledPIDCommand.java | 2 ++ .../main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java | 1 + .../edu/wpi/first/wpilibj2/command/SequentialCommandGroup.java | 1 + 8 files changed, 9 insertions(+) diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ConditionalCommand.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ConditionalCommand.java index 15c8674da7b..1d2661afb6a 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ConditionalCommand.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ConditionalCommand.java @@ -32,6 +32,7 @@ public class ConditionalCommand extends Command { * @param onFalse the command to run if the condition is false * @param condition the condition to determine which command to run */ + @SuppressWarnings("this-escape") public ConditionalCommand(Command onTrue, Command onFalse, BooleanSupplier condition) { m_onTrue = requireNonNullParam(onTrue, "onTrue", "ConditionalCommand"); m_onFalse = requireNonNullParam(onFalse, "onFalse", "ConditionalCommand"); diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/PIDCommand.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/PIDCommand.java index fed674413b6..360e15bf9d4 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/PIDCommand.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/PIDCommand.java @@ -39,6 +39,7 @@ public class PIDCommand extends Command { * @param useOutput the controller's output * @param requirements the subsystems required by this command */ + @SuppressWarnings("this-escape") public PIDCommand( PIDController controller, DoubleSupplier measurementSource, diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelCommandGroup.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelCommandGroup.java index 14d93b6961c..0fc31876ce4 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelCommandGroup.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelCommandGroup.java @@ -32,6 +32,7 @@ public class ParallelCommandGroup extends Command { * * @param commands the commands to include in this composition. */ + @SuppressWarnings("this-escape") public ParallelCommandGroup(Command... commands) { addCommands(commands); } diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java index 86417f27b9c..2286cee7de8 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelDeadlineGroup.java @@ -40,6 +40,7 @@ public class ParallelDeadlineGroup extends Command { * @param otherCommands the other commands to be executed * @throws IllegalArgumentException if the deadline command is also in the otherCommands argument */ + @SuppressWarnings("this-escape") public ParallelDeadlineGroup(Command deadline, Command... otherCommands) { setDeadline(deadline); addCommands(otherCommands); diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java index bd2b214d106..36eaf275431 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ParallelRaceGroup.java @@ -32,6 +32,7 @@ public class ParallelRaceGroup extends Command { * * @param commands the commands to include in this composition. */ + @SuppressWarnings("this-escape") public ParallelRaceGroup(Command... commands) { addCommands(commands); } diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ProfiledPIDCommand.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ProfiledPIDCommand.java index 39bdf246c18..b22ff51c4a3 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ProfiledPIDCommand.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/ProfiledPIDCommand.java @@ -42,6 +42,7 @@ public class ProfiledPIDCommand extends Command { * @param useOutput the controller's output * @param requirements the subsystems required by this command */ + @SuppressWarnings("this-escape") public ProfiledPIDCommand( ProfiledPIDController controller, DoubleSupplier measurementSource, @@ -70,6 +71,7 @@ public ProfiledPIDCommand( * @param useOutput the controller's output * @param requirements the subsystems required by this command */ + @SuppressWarnings("this-escape") public ProfiledPIDCommand( ProfiledPIDController controller, DoubleSupplier measurementSource, diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java index b888e98eb5f..2712b4508e6 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SelectCommand.java @@ -38,6 +38,7 @@ public class SelectCommand extends Command { * @param commands the map of commands to choose from * @param selector the selector to determine which command to run */ + @SuppressWarnings("this-escape") public SelectCommand(Map commands, Supplier selector) { m_commands = requireNonNullParam(commands, "commands", "SelectCommand"); m_selector = requireNonNullParam(selector, "selector", "SelectCommand"); diff --git a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SequentialCommandGroup.java b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SequentialCommandGroup.java index 905b8a6bbd3..5d6b2cd1e58 100644 --- a/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SequentialCommandGroup.java +++ b/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SequentialCommandGroup.java @@ -29,6 +29,7 @@ public class SequentialCommandGroup extends Command { * * @param commands the commands to include in this composition. */ + @SuppressWarnings("this-escape") public SequentialCommandGroup(Command... commands) { addCommands(commands); }