-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative track source does not persist after closing the app. #1223
Comments
Can you specify what song(s) it's happening with? Because I was unable to reproduce this issue. As long as you've not changed the audio source ("Settings" > "Audio Source") before playing that particular song once again, it should remember the manually selected match |
I'm also having the same issue -- this is the song https://open.spotify.com/track/57gvyHE7smXf3gaRH794lt Something quite odd, at first it plays an episode from the Critical Role podcast. If I look at the alternative sources, there are none unless I click the magnifying glass and change the search from "lievery voice - main vox mix - Jasper Street Co., Mousse T." to "lift every voice - main vox mix - Jasper Street Co., Mousse T." (for some reason the "ft" is missing from the original search. When I choose the alternative track, it will remember the selection until I close and reopen Spotube, then it goes back to the original result |
Looks like the regex that cleans the track title is removing the |
This line is the culprit spotube/lib/utils/service_utils.dart Line 57 in 5d0b5e6
It should match the whole word only but it's replacing parts of the word and there should've been a |
Sorry for the late reply! Basically, any of them; I'm testing right now with https://open.spotify.com/track/46scODShYFATHbLfLE0dr1 (it finds the Midnight version) or https://open.spotify.com/track/6rdkCkjk6D12xRpdMXy0I2 (completely wrong song). |
@KRTirtho This is still happening on Spotube 3.6.0 on Windows 10. When changing the source of this song (https://open.spotify.com/track/7uUoiK8yQQrsuk5iF1dlFA), no alternatives come up until you click the Search button (this happens to all songs by the way). Manually selecting the Official Audio version causes it to play correctly, but as soon as it goes to the next or previous song, then back to this one, or exiting the app and reopening it again, the default source is back to the Official Video version. I don't think it's an issue specific to this song, it happens on any song I've tried it so far. Let me know if I can help resolve this issue by testing and troubleshooting further. :) |
This has been fixed in #1687 |
I'm still having this issue with more than one song :) https://song.link/s/3rCJptQKkXrTx6qUXqz7dD |
It seems like in the version 3.8.0 in android, the bug is solvented, I still have to do more tests, thanks!! |
Is there an existing issue for this?
Current Behavior
Although the patch notes said it should be fixed, when I select a new alternative track source and close the app, it goes back to the original selection ignoring my choice.
Expected Behavior
After selecting a new alternative track source, it should be mantained even after closing the app and not reset to the original choice.
Steps to reproduce
Operating System
Windows 11
Spotube version
v3.4.1 (latest)
Installation source
GitHub Releases (Binary)
Additional information
This is especially strange since I managed to keep only one song with an alternative track source, but any other just revert back. I did try uninstalling and reinstalling, no changes. This is technically a duplicate of #840, but it's not resolved for me.
Self grab
The text was updated successfully, but these errors were encountered: