Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global - Most/all placeables do not have shadows enabled #797

Open
DarthParametric opened this issue Apr 16, 2024 · 1 comment
Open

Global - Most/all placeables do not have shadows enabled #797

DarthParametric opened this issue Apr 16, 2024 · 1 comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Global Issue occurs across all modules Type: Asset This issue is related to specifically to an asset like a model, texture, etc.

Comments

@DarthParametric
Copy link
Contributor

DarthParametric commented Apr 16, 2024

Presumably for performance reasons, Bioware did not enable shadows on most placeables. This is particularly noticeable in some instances, for example if the player is ambushed outside the Tatooine krayt dragon cave where the swoops/speeders don't have shadows but their passengers do.

It's relatively simple to rectify this, although there are potentially compatibility ramifications if we mass-replace placeable models. Perhaps just a strategic selection? These are the obvious ones that come to mind:

  • Junk landspeeder (PLC_JnkSpdr1 / PLC_JnkSpdr2)
  • Junk swoop bike (PLC_JnkSwpB1 / PLC_JnkSwpB2) - tweak walkmesh for bike 2
  • Landspeeder (PLC_LndSpdr1 / PLC_LndSpdr2 / PLC_LndSpdr3)
  • Swoop bike (PLC_SwpBike1 / PLC_SwpBike2)
  • Computer panel (PLC_CompPnl)
  • Computer panel wall (PLC_CompPnl2)
  • Workbench (PLC_RepTab1 / PLC_RepTab2) - tweak walkmesh for both
  • Footlocker (PLC_FootLker)
  • Plascrete cylinder ( PLC_PlstcCrt)
  • Octagonal metal box (PLC_MetalBox)
  • Star map (PLC_StarMap)

We already replace the star map (added animation) and junk swoop bikes (fixed windscreen), so some of these wouldn't be a problem. I'd probably need to wander around some modules and see if there are any other obvious additions. Perhaps some of the desks.

Tat_Comparison_01

Tat_Comparison_02

Edit: The star map already has shadows enabled. Guess I did that already when adding the extra animations.

Edit 2: Additionally, we could take this opportunity to tweak the walkmeshes of some of these placeables. I've noted which warrant it above.

@DarthParametric DarthParametric added Minor Issue Aesthetic issue or other problem that isn't really a bug Type: Asset This issue is related to specifically to an asset like a model, texture, etc. Module: Global Issue occurs across all modules labels Apr 16, 2024
@Salk73
Copy link

Salk73 commented Apr 16, 2024

Can't say I ever noticed. If there are potential issues reinstating the shadows, I'd rather see this done only for those cases where the lack of shadows is most noticeable (Tatooine ambush).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Global Issue occurs across all modules Type: Asset This issue is related to specifically to an asset like a model, texture, etc.
Projects
None yet
Development

No branches or pull requests

2 participants