Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation returns undocumented status code 400 #57

Open
mvanbrab opened this issue Jan 19, 2021 · 0 comments
Open

Implementation returns undocumented status code 400 #57

mvanbrab opened this issue Jan 19, 2021 · 0 comments
Labels
enhancement New feature or request priority:medium

Comments

@mvanbrab
Copy link
Collaborator

Detected in version

commit 5205e36 on branch development

How to trigger

Start:

yarn start -c example/config.yaml

Get (in new terminal window)

# 200, no problem here:
wget http://localhost:3000/artist/David%20Bowie?writer=John%20Lennon
# 400, because of missing parameter:
wget http://localhost:3000/artist/David%20Bowie

Proposed solution

  • Keep code assigning status 400 (in handlers/request-handler.js)
  • Modify appropriate wrong test description (in test/test.js) 'should return status 404 when the GraphQL-LD query's required variables were not given'
  • Handle status code 400 in all appropriate configuration(s)
  • Document status 400 in README.md
@pheyvaer pheyvaer added enhancement New feature or request priority:medium labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants