Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make Hold-Tap work with transparent keycodes #1039

Open
hariganti opened this issue Oct 30, 2024 · 2 comments
Open

[Enhancement] Make Hold-Tap work with transparent keycodes #1039

hariganti opened this issue Oct 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hariganti
Copy link

hariganti commented Oct 30, 2024

Describe the bug
When using hold-tap (KC.HT(KC.TAP, KC.HOLD)), using KC.TRNS for the tap action doesn't properly send the keycode that should be sent.

To Reproduce
Steps to reproduce the behavior:

from kmk.keys import KC
CUST = KC.HT(KC.TRNS, KC.LCTL)
Keyboard.keymap = [
  [ ... KC.A, KC.B ... ],
  [ ... CUST, CUST ... ]
]
  1. Activate second layer
  2. Press 'B'
  3. Press 'A'
  4. Release 'A'
  5. Release 'B'

Expected behavior
Control + A (select all) should be the result

Debug output
No output available at this time

Additional context
What I'd like to do is have a layer with home row mods, so holding a key will momentarily enable that layer, then holding one of the hold-tap keys will give me the desired modifier. As I have other layers, using the transparency keycode for the tap function is desirable since it will allow me to use the home row mods on whichever layer I was actively using before activating the momentary layer. This is also why I can't just do something like, KC.HT(KC.A, KT.LCTL), since that won't allow me to use control as a modifier on all layers

@hariganti hariganti added the bug Something isn't working label Oct 30, 2024
@xs5871 xs5871 added enhancement New feature or request and removed bug Something isn't working labels Oct 31, 2024
@xs5871
Copy link
Collaborator

xs5871 commented Oct 31, 2024

That's a feature request. The transparent key resolution happens at a completely different part of the code.

@xs5871 xs5871 changed the title [BUG] Hold-Tap doesn't appear to work with transparent keycodes [Enhancement] Make Hold-Tap work with transparent keycodes Oct 31, 2024
@hariganti
Copy link
Author

Thanks for the correction. It appeared like a bug since I didn't see anything to indicate that the transparency keycode couldn't be used there in the way I tried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants