Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip the requirements check for training and serving jobs #69

Open
ImScientist opened this issue Nov 6, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ImScientist
Copy link
Contributor

At the moment, kaos checks if:

  • train, __init__.py is present in the model root directory if you want to use kaos train deploy
  • serve, __init__.py, web-requirements.txt is present in the model root directory if you want to use kaos serve deploy

What is the desired change?

In order to have a clean environment a user could decide to move all of the necessary files (serve, __init__.py, web-requirements.txt, wigs.py, nginx.conf) to a separate directory and modify the Dockerfile to copy the content from that directory to the model root directory. An addition of the option -f to the cli that skips the project structure check would be required in this case.

How will this change improve kaos?

It will give more flexibility to users that know what they do.

Any thoughts on the implementation approach?

It seems doable to tell your algorithm to skip some checks if -f option is present.

@github-actions
Copy link

github-actions bot commented Nov 6, 2019

Thanks for supporting the development of kaos with your first issue! We look forward to handling it.

@jfri3d jfri3d added enhancement New feature or request good first issue Good for newcomers labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants