Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIM returns nothing #58

Open
aymeric75 opened this issue Oct 21, 2022 · 12 comments
Open

TIM returns nothing #58

aymeric75 opened this issue Oct 21, 2022 · 12 comments

Comments

@aymeric75
Copy link

domainPlusproblem.zip

Hello,

When using:

./TIM domain.pddl problem.pddl

it outputs absolutly nothing. Is there something wrong with the pddls ? (here attached).

Thanks a lot

Aymeroc

@DerekLong101
Copy link
Contributor

DerekLong101 commented Oct 21, 2022 via email

@aymeric75
Copy link
Author

aymeric75 commented Oct 21, 2022

Thanks a lot for this detailed answer.

Is your domain a real representation of something meaningful, or a randomly generated structure?

These PDDL was generated by Lat Plan ( repo here ). In short, it's a neural network that generates it.

There is a problem with your problem file: initial states are built with the closed world assumption, so negative facts are never placed in there.

In the problem file, the initial state is specified with a value of truth for all 50 variables, some of true, some are false, but I don't see how it can break the parser honestly...

@DerekLong101
Copy link
Contributor

DerekLong101 commented Oct 21, 2022 via email

@maltehelmert
Copy link

Regarding invariant finders that work on pure propositional variables, the h^2-based mutex analysis does that. Jussi Rintanen's invariant synthesis algorithm is equivalent. (Jussi also has a lifted algorithm, but it doesn't find more invariants, but rather exists for efficiency reasons.) But from other discussions I think Aymeric is already aware of this (specifically, Alvaro Torralba's implementation), so I'm just mentioning it here more for the benefit of others that might follow the discussion.

@alfonsogerevini
Copy link

Hello everyone! :-)
Regarding invariant finders that work on pure propositional variables, Discoplan does support them.

Best, Alfonso

@aymeric75
Copy link
Author

Indeed, I found invariants with both h2 preprocessor (mutex for now) and Discoplan (equivalences for now)

@aymeric75
Copy link
Author

aymeric75 commented Oct 24, 2022

It breaks the parser because the parser does not expect tokens of the form (not (...)) in the initial state and treats them as errors (the BNF does not allow them, so that is correct). The parser is not particularly well instrumented (in VAL/TIM) for error cases - it often simply crashes. I don't think any of the invariant finders work on pure propositional variables, but I might be wrong. TIM in this implementation is probably not going to do what you want, because it doesn't output invariants in an obvious way.............

I will remove the not variables from the initial state and keep you updated. Thanks

@aymeric75
Copy link
Author

Hello, I removed the "not" variables from the initial state, still nothing, maybe as you said, no invariants can be found with TIM on this domain.
problem.txt
domain.txt

@DerekLong101
Copy link
Contributor

DerekLong101 commented Oct 28, 2022 via email

@aymeric75
Copy link
Author

ok thanks, but is there a version of TIM with this feature ? If yes, I could try

@DerekLong101
Copy link
Contributor

DerekLong101 commented Oct 28, 2022 via email

@aymeric75
Copy link
Author

Hello Derek,

Were you able to find the "0-analysis" version of TIM ?

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants