Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default espislon to 0.001 instead of 0.01 in Validate to be consistent with POPF ? #41

Open
gbesancon-schlumberger opened this issue Aug 5, 2019 · 2 comments

Comments

@gbesancon-schlumberger
Copy link
Contributor

gbesancon-schlumberger commented Aug 5, 2019

Change the default epsilon value from 0.01 to 0.001 Validate to be consistent with POPF ?

@DerekLong101
Copy link
Contributor

I prefer to leave this as 0.01 for legacy consistency. Users should be aware that it needs to be set for validation of a plan in specific contexts.

@jan-dolejsi
Copy link
Contributor

Suggestion: when the plan is found invalid for a temporal consistency reason, the -t suggestion is printed as part of the output. The smallest time increment in the plan could also be used to determine whether epsilon is set correctly. E.g. we observe the time increments in this plan are as small as 0.001, consider using the -t switch to set the same epsilon time step that was used by the planner that created this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants