Add shutdown confirmation window

[Botan626]

Checklist

• I also read FAQ
• This is not ASF suggestion
• I read and understood ASF-ui's Contributing Guidelines
• My idea doesn't duplicate existing ASF-ui functionality described on the wiki
• I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality

Enhancement purpose

I just accidentally pressed on Shutdown button in ui and ASF was shut down immediately.

To prevent such accidental and unwished exists, ui could ask user if he really wants to exit, with a dialog like this:

Also an extra UI setting "Confirmation on exit" would be handy to have too.

[WiLuX-Source]

How does one quit acciddentally when you have to click minimum 2 times in order to shutdown this program?
If your mouse had double click issues it would just close the expanded menu. I don't get this at all.

[Botan626]

I don't get this at all.

Explanation is rather easy and obvious. Above shutdown button there are 2 more of them. I wanted to press restart, but my right hand at this exact moment twitched involuntarily, I pressed shutdown button and it was an immediate end for ASF.

I strongly believe this issue should be addressed, and exit confirmations could be off in ui settings by default, so most users won't need to configure ui in this regard, but those users, who want exit confirmations, will turn it on.

[Botan626]

my right hand at this exact moment twitched involuntarily, I pressed shutdown button and it was an immediate end for ASF

Another case is that user can simply missclick on shutdown button and then ASF will be closed right away as well.

[Aareksio]

Did anything break after you started ASF again? Was ASF working on any long-running non-resumable job when it quit? Or was there are any data stored in memory which got wiped the moment it exited and you lost the progress because it did not save on exit?

If any data loss has occurred, I suggest reporting this to ASF repo as exit command should exit gracefully allowing all processes to save to disk to avoid data loss.

[Botan626]

Did anything break after you started ASF again? Was ASF working on any long-running non-resumable job when it quit? Or was there are any data stored in memory which got wiped the moment it exited and you lost the progress because it did not save on exit?

If any data loss has occurred, I suggest reporting this to ASF repo as exit command should exit gracefully allowing all processes to save to disk to avoid data loss.

This issue is about preventing unwanted accidental exits, not about what's going after such exits.

[Aareksio]

I am attempting to determine whether exiting after the user clicks a button is a bug or a feature. If an action is non-destructive, such as pressing "Comment" button here on GitHub, there is no reason to double check user intention. Double checking is reserved for destructive actions which can not be easily undone. Have you suffered any considerable damage as a result of exiting ASF via dedicated button in the UI?

[Botan626]

I am attempting to determine whether exiting after the user clicks a button is a bug or a feature.

It's already a feature. Users click on buttons and something happens.

Double checking is reserved for destructive actions which can not be easily undone.

Only for destructive? Why?

Have you suffered any considerable damage as a result of exiting ASF via dedicated button in the UI?

I could redeem lots of keys, or ASF could download an update, maybe ASF would exit during installing an update idk, or I could transfer items, I think ASF can do many things during which false exits would be unwanted.

This was not the 1st time when I mistakenly pressed shutdown button. I suggested such confirmation can be optional in ui settings and be off by default, personally I would turn it on.