fix: doesnt call dipose callback when full reload is aked

Julien-R44 · Julien-R44 · commit d88ce830763b · 2024-04-07T18:05:04.000+02:00
diff --git a/packages/hot_hook/src/hot.ts b/packages/hot_hook/src/hot.ts
@@ -23,6 +23,7 @@ class Hot {
       if (this.#hasOneDeclinedPath(message.paths)) {
         process.send?.({ type: 'hot-hook:full-reload', paths: message.paths })
         this.#options.onFullReloadAsked?.()
+        return
       } else {
         process.send?.({ type: 'hot-hook:invalidated', paths: message.paths })
       }

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ class Hot {`
`23`	`23`	`if (this.#hasOneDeclinedPath(message.paths)) {`
`24`	`24`	`process.send?.({ type: 'hot-hook:full-reload', paths: message.paths })`
`25`	`25`	`this.#options.onFullReloadAsked?.()`
	`26`	`+ return`
`26`	`27`	`} else {`
`27`	`28`	`process.send?.({ type: 'hot-hook:invalidated', paths: message.paths })`
`28`	`29`	`}`