Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Slice mutating functions #9

Open
washley opened this issue Mar 2, 2020 · 3 comments
Open

[Feature Request] Slice mutating functions #9

washley opened this issue Mar 2, 2020 · 3 comments

Comments

@washley
Copy link

washley commented Mar 2, 2020

First of all, thanks for writing this crate!

It would be pretty awesome if the slice types had functions to modify attributes, and these wrote-through to the underlying slice.

Another optimization that could be made here is that, since we know what's changing, you can perform an optimized checksum recalculation (see https://tools.ietf.org/html/rfc1631 section 3.3).

@washley
Copy link
Author

washley commented Mar 2, 2020

Of course now I see the roadmap, and this is on there. I don't know if you prefer to close this or leave it open, I'll leave that up to you.

@thomaseizinger
Copy link

A heads-up that we started to use etherparse with the need to mutate certain parts of the IP header: https://github.com/firezone/firezone/pull/6524/files#diff-5501ead477be03a5eea0d523140b1b4ba2c58647d04b6b1b518e4fd58b31b1df

We plan on upstreaming these eventually.

@JulianSchmid
Copy link
Owner

Hi @thomaseizinger ,

Great to hear. Just open up a pull request if you are ready.

Greets
Julian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants