Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why PacketBuilder::ipv4() takes [u8;4] as its ip arguments? #104

Open
lyoh33 opened this issue Jul 18, 2024 · 0 comments
Open

Why PacketBuilder::ipv4() takes [u8;4] as its ip arguments? #104

lyoh33 opened this issue Jul 18, 2024 · 0 comments

Comments

@lyoh33
Copy link

lyoh33 commented Jul 18, 2024

Thanks for your great working for this crate, but [u8; 4] is not convinient as input type.
Do you have any plan that implement a trait like
pub trait IntoIpv4Addr{ fn into_ipv4(&self) -> Result<Ipv4Addr> }
and change the method to
pub fn ipv4<A: IntoIpv4Addr>(source: A, ...) -> PacketBuilderStep<IpHeaders>
or any other alternative way to make life easier?
I hope I've made myself clear

@lyoh33 lyoh33 closed this as completed Jul 18, 2024
@lyoh33 lyoh33 reopened this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant