Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maybe] Refactor Jackknife and CV methods (DRY) #46

Open
pat-alt opened this issue Dec 7, 2022 · 0 comments
Open

[maybe] Refactor Jackknife and CV methods (DRY) #46

pat-alt opened this issue Dec 7, 2022 · 0 comments
Labels
medium This is expected to be medium. wontfix This will not be worked on

Comments

@pat-alt
Copy link
Member

pat-alt commented Dec 7, 2022

Currently we have separate constructors for Jackknife and CV methods, e.g. JackknifePlusRegressor and CVPlusRegressor. Since the former is just a special case of the latter (for which nfold=nobs), technically this makes the former constructor redundant. By getting rid of it we could make the code base more DRY ("don't repeat yourself").

The problem with this idea is that at instantiation the models have no access to data, so nobs is unknown. So if we want to keep a separate model type (JackknifePlusRegressor), then making the code more DRY would come with its own complications.

Currently undecided, so won't fix myself, but leaving this here for discussion.

@pat-alt pat-alt added wontfix This will not be worked on medium This is expected to be medium. labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium This is expected to be medium. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant